fix: remove duplicate entries in PATH #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the environment variable may be longer than 128KiB, which Linux does not allow (spawn fails with E2BIG).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the environment variable may be longer than 128KiB, which Linux does not allow (spawn fails with E2BIG).
There are various bug reports related to E2BIG failures:
pnpm/pnpm#6106
pnpm/pnpm#8552
I'm not sure how to handle project paths that contain a colon
:.And I'm not sure whether this would be the "best" fix, because it would certainly be better to address the issue at the root cause (somewhere else in pnpm the PATH variable is generated with duplicate entries).